Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Fix /metrics end-point. #2717

Merged
merged 3 commits into from
Jun 22, 2020

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Jun 18, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Fix /metrics end-point.

Why

Running Horizon with ADMIN_PORT enabled will cause a panic when trying to fetch the metrics since it was being setup before initializing the metrics registry.

Fix #2714

Known limitations

@cla-bot cla-bot bot added the cla: yes label Jun 18, 2020
@abuiles abuiles requested a review from a team June 18, 2020 20:02
@bartekn bartekn merged commit 28355c0 into stellar:release-horizon-v1.5.0 Jun 22, 2020
@abuiles abuiles deleted the fix-metrics branch June 22, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants